test: remove test-sqlite-statement-sync flaky designation #56051
+0
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
The issue is likely the same as other tests that time out. Refs: nodejs#54918 Refs: nodejs#54802
targos
approved these changes
Nov 28, 2024
lpinca
force-pushed
the
remove/flaky-test-sqlite-statement-sync
branch
from
421783b to
68be957
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56051 +/- ##
==========================================
- Coverage 87.97% 87.96% -0.01%
==========================================
Files 656 656
Lines 188383 188383
Branches 35973 35971 -2
==========================================
- Hits 165732 165716 -16
- Misses 15821 15837 +16
Partials 6830 6830 |
github-actions
bot
removed
the
request-ci
|
@targos would you mind re-approving so that this can land? Thank you. |
|
@nodejs/testing |
targos
approved these changes
Dec 17, 2024
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 6536978 |
aduh95
pushed a commit
that referenced
this pull request
Dec 18, 2024
The issue is likely the same as other tests that time out. Refs: #54918 Refs: #54802 PR-URL: #56051 Reviewed-By: Michaël Zasso <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Dec 18, 2024
The issue is likely the same as other tests that time out. Refs: #54918 Refs: #54802 PR-URL: #56051 Reviewed-By: Michaël Zasso <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Dec 20, 2024
The issue is likely the same as other tests that time out. Refs: #54918 Refs: #54802 PR-URL: #56051 Reviewed-By: Michaël Zasso <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Dec 21, 2024
The issue is likely the same as other tests that time out. Refs: #54918 Refs: #54802 PR-URL: #56051 Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is likely the same as other tests that time out.
Refs: #54918
Refs: #54802